sakai.iframe.site isn't translated properly after SAK-8908

Description

We have installed Sakai 2.7.0-RC01, which has included in the kernel the fix for SAK-8908.

All the tools and pages titles are properly translated, with exception of the tool "sakai.iframe.site" when added to Home pages.

The other tools of Home (i.e. "sakai.synoptic.calendar") work fine.

We have the key "sakai.iframe.site" configured in tools_es.properties and tools_eu.properties, but the translation doesn't work.

Activity

Daniel Merino July 27, 2010 at 12:26 AM

I have been investigating a little about this.

The problem is that, while "sakai.iframe" is a full "legacy" tool, that must be configured by the users in their Web Content tools, the tools "sakai.iframe.site" and "sakai.iframe.workspace" seems to be more static, traditional tools.

Both tools are configured in the Home pages of sites and user's workspaces respectively and, AFAIK, they are planned to be pre-configured information pages, as the other synoptic tools. Users can't add more than one of these tools in the Home page, at least in the Sakais which I have seen. They only can edit its content.

We don't let our users to edit the titles of these pages, as they can do with the usual "sakai.iframe" tool. I think that it has no sense to edit the title of the tool "sakai.iframe.myworkspace", as it is in the personal workspaces of the users, so only theyselves can see that title.

Editing the title of "sakai.iframe.site" has more sense, but IMHO it should be treated as the other tools, with the customTitle property setted when the user edit it.

Anyway, as is our personal opinion, I have solved it in our installation commenting these two lines in BaseToolConfiguration.java:

/**

  •  

    • Checks if the tool's page has set the custom_title property (for custom page or tool titles),

    • or alternately checks if this tool should be cosidered a "legacy" custom tool title

    • (e.g. iframe, news, linktool).
      **

    • @see org.sakaiproject.site.impl.BaseSitePage#getTitleCustom
      **/
      private boolean getTitleCustom(SitePage page)
      {
      String custom = (String)page.getProperties().get(SitePage.PAGE_CUSTOM_TITLE_PROP);
      if ( custom != null )
      return Boolean.parseBoolean(custom);
      else if ( "sakai.iframe".equals(m_toolId) || "sakai.news".equals(m_toolId) || "sakai.rutgers.linktool".equals(m_toolId) )
      return true;
      //else if (m_toolId != null && m_toolId.startsWith("sakai.iframe"))
      // return true;
      else
      return false;
      }

Beth Kirschner July 23, 2010 at 8:11 AM

The Admin Sites Tool change described in provides administrators an option for resetting the custom-title flag for pages. The SQL described in describes how to go about using SQL to reset the custom-title flag.

Daniel Merino July 5, 2010 at 3:22 AM

We have discovered that deleting the Home title in "Page Order" (trying to solve http://jira.sakaiproject.org/browse/SAK-18734) makes this title to be correctly internationalized in the site's Home page.

Unfortunately, in the MyWorkspace's Home page we haven't a "Page Order" tool to do the same.

Now, my question: is this behaviour repeatable in the BBDD with some SQL, so we can fix this problem in all our sites in a single sentence?

Beth Kirschner July 2, 2010 at 8:40 AM
Edited

This is due to KNL-447, which provides for exceptions to localizations for web content pages, as needed by SAK-17863. There are conflicting requirements between this issue and that need to be resolved.

Incorporated

Details

Priority

Affects versions

Components

Assignee

Reporter

Created July 2, 2010 at 4:12 AM
Updated March 27, 2012 at 7:05 AM
Resolved July 23, 2010 at 8:11 AM