Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

mysql 2.6.0-2.6.1 conversion script: comments not formatted properly

Description

For our version of mysql (5.0.45), when we run sakai_2_6_0-2_6_1_mysql_conversion.sql any comments that contain no space between the '--' and the actual comment confuse mysql and cause it to error.

Good:
– Here is my comment!

Bad:
--Here is my comment!

Attachments

1

Activity

Anthony Whyte August 10, 2010 at 5:06 PM

Merged to 2.6.x, 2.6.3, 2.7.x and 2.7.1 branches.

Sam Ottenhoff August 5, 2010 at 8:11 AM

Confirmed fixed in trunk. I tested on a Windows MySQL 5.1 instance and a Linux 5.0 MySQL instance.

For future reference (if this comes up again), here is proper MySQL commenting syntax:

http://dev.mysql.com/doc/refman/5.0/en/comments.html

--------------- "From a "-- " sequence to the end of the line. In MySQL, the "-- " (double-dash) comment style requires the second dash to be followed by at least one whitespace or control character (such as a space, tab, newline, and so on). This syntax differs slightly from standard SQL comment syntax, as discussed in Section 1.8.5.5, "'--' as the Start of a Comment".

Sam Ottenhoff August 5, 2010 at 8:04 AM

Subversion commit is not showing up because of bad JIRA # in commit.

The commit is r79152.

Here is the diff:

https://source.sakaiproject.org/viewsvn/reference/trunk/docs/conversion/sakai_2_6_0-2_6_1_mysql_conversion.sql?r1=68273&r2=79152

David Horwitz July 7, 2010 at 9:28 AM

Thanks for the patch Nicola!

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Conversion Script Required

Yes

Created June 11, 2010 at 9:34 AM
Updated August 10, 2010 at 5:06 PM
Resolved July 7, 2010 at 9:28 AM