design for importing tools is really ugly, will make migrating to new versions difficult

Description

The code in common SiteMerger gets the XML tag name in the import file, and looks it up using ComponentManager.get(serviceName). That means that the XML tag name is tied to the actual bean implementing the import. This is crazy. This is already out of date, so there's a list of old names to map to new names. And if there's ever a major redesign of Sakai, this is likely to be completely inappropriate.

You've got a function EntityManager.getEntityProducers() that will give you all of the entity producers. Why not just add a getTagNames() function to the API, and build a hash table of tag name to class? (I say getTagNames so that a class can handle more than one tag name, in case you need to change tag names or have one class handle multiple ones.)

Activity

Neal Caidin August 14, 2017 at 2:02 PM

Bulk closing issues that have not been updated since 2014 and earlier. Please reopen if this is still an issue and you have new information.

Jean-François Lévêque February 12, 2013 at 2:30 AM

Chuck, it this is still happening with 2.8 or later, please follow Steve's latest instructions.

Steve Swinsburg June 5, 2010 at 3:45 PM

Sorry I meant clone, not close. Attach the relevant components to this (Archive, Common, Site Manage) but if there are any that have been moved to the kernel, ire if it affects a kernel service or work needs doing there, you'll need a KNL issue.

Charles Hedrick June 5, 2010 at 3:41 PM

The code is in archive, common and site-manage. None of those are in the kernel directory. Do you consider them part of the kernel?

Steve Swinsburg June 5, 2010 at 3:39 PM

Entity Service is pre-K1 only, you'll need to close this and move it to a KNL issue to track it in K1.

Won't Fix

Details

Priority

Affects versions

Components

Assignee

Reporter

Created June 5, 2010 at 6:11 AM
Updated August 14, 2017 at 2:02 PM
Resolved August 14, 2017 at 2:02 PM