Presence list creates unnecessary objects (expensive CPU/GC)

Description

I was looking at the performance of the presence service and was seeing lots of GC activity when attempting to push presence hard. Tracing the objects created led me back to the PresenceTool doing lots of org.sakaiproject.util.ResourceLoader.getString() calls which although it isn't very slow it was being performed in a loop.

Attachments

1

Activity

Steve Swinsburg June 27, 2010 at 8:37 PM

2.5.x, r78835

Jonathan Cook May 11, 2010 at 1:22 PM

2.7.x, r77387
2.6.x, r77388

Stephen Marquard May 11, 2010 at 5:26 AM

Tested this on a trunk build, no regressions.

amberg1 May 11, 2010 at 2:43 AM

Does this have impact on 2.7.x

Matthew Buckett May 11, 2010 at 2:39 AM

Patch to move the getting of the resource string outside the loop.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created May 11, 2010 at 1:33 AM
Updated June 29, 2010 at 5:01 PM
Resolved May 11, 2010 at 2:45 AM