Steps to replicate ---------------------------
1) Create a course site 2) Go to Administration Workspace -> Sites 3) Edit the newly-created site 4) Go to Pages 5) Click on a page name 6) Modify the page title (e.g., change "Wiki" to "MyWiki") 7) Save
Current Behavior: newly-modified page title is not saved
Fixed – the default (localized) title is always used unless the customTitle flag is set, as described in SAK-16686. Fix is trivial.
Zhen Qian December 16, 2009 at 11:06 AM
Things are working fine inside Admin Site tool.
The reason that the modified title is not saved is because the inside the saveTx(Site edit) of DbSiteService, page.getTitle() always returns the title from tool registration file, not from what user typed.
This is related to change to getTitle() in BaseSitePage.java:
" ... // Custom page/tool titles are not localized (e.g. News, Web Content) if ( getTitleCustom() ) return m_title;
// otherwise, return attempt to return a localized title else { Tool localTool = ActiveToolManager.getTool(toolId); if (localTool != null) { return ActiveToolManager.getTool(toolId).getTitle(); } } ... " It looks that the ActiveToolManager.getTool(toolId).getTitle() is always called, and hence returns the default title.
I am assigning this to Beth, since Beth knows more about the changes.
Thanks,
Zhen
Sam Ottenhoff December 16, 2009 at 8:47 AM
According to SAK-17591, this also applies to Tool titles.
Steps to replicate
--------------------------- 1) Create a course site
2) Go to Administration Workspace -> Sites
3) Edit the newly-created site
4) Go to Pages
5) Click on a page name
6) Modify the page title (e.g., change "Wiki" to "MyWiki")
7) Save
Current Behavior: newly-modified page title is not saved