Search cannot be built with unit tests running under java 1.6
The build fails during tests: /opt/sakai-trunk/search/search-impl/impl/src/test/org/sakaiproject/search/indexer/impl/test/TDataSource.java:[98,2] <anonymous org.sakaiproject.search.indexer.impl.test.TDataSource$1> is not abstract and does not override abstract method isWrapperFor(java.lang.Class<?>) in java.sql.Wrapper
/opt/sakai-trunk/search/search-impl/impl/src/test/org/sakaiproject/search/indexer/impl/test/TDataSource.java:[109,4] <anonymous org.sakaiproject.search.indexer.impl.test.TDataSource$1$1> is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
/opt/sakai-trunk/search/search-impl/impl/src/test/org/sakaiproject/search/index/soaktest/SharedTestDataSource.java:[120,2] <anonymous org.sakaiproject.search.index.soaktest.SharedTestDataSource$1> is not abstract and does not override abstract method isWrapperFor(java.lang.Class<?>) in java.sql.Wrapper
/opt/sakai-trunk/search/search-impl/impl/src/test/org/sakaiproject/search/index/soaktest/SharedTestDataSource.java:[142,4] <anonymous org.sakaiproject.search.index.soaktest.SharedTestDataSource$1$1> is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
Updating these classes to include the 1.6 methods will allow the tests to run and will remain compatible with java 1.5
Marking the issue as fixed as it has been fixed in SVN for some time now.
Matthew Buckett February 16, 2010 at 5:49 AM
My patch fixed the issue, Aaron just didn't like the solution I implemented.
amberg1 February 16, 2010 at 5:44 AM
Unit tests are important for defending and improving the quality of Sakai. If any are broken we should repair and even add more.
Aaron Zeckoski December 13, 2009 at 2:08 AM
I think this needs a little more review and dicsussion so I am reopening, it should be looked at by the main team
Aaron Zeckoski December 13, 2009 at 2:06 AM
We should make sure this works in the IBM VM (since websphere support is part of trunk). It may be good to also to check it against jRockit as a litmus test (though this should be done for everything in sakai trunk).
Search cannot be built with unit tests running under java 1.6
The build fails during tests:
/opt/sakai-trunk/search/search-impl/impl/src/test/org/sakaiproject/search/indexer/impl/test/TDataSource.java:[98,2] <anonymous org.sakaiproject.search.indexer.impl.test.TDataSource$1> is not abstract and does not override abstract method isWrapperFor(java.lang.Class<?>) in java.sql.Wrapper
/opt/sakai-trunk/search/search-impl/impl/src/test/org/sakaiproject/search/indexer/impl/test/TDataSource.java:[109,4] <anonymous org.sakaiproject.search.indexer.impl.test.TDataSource$1$1> is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
/opt/sakai-trunk/search/search-impl/impl/src/test/org/sakaiproject/search/index/soaktest/SharedTestDataSource.java:[120,2] <anonymous org.sakaiproject.search.index.soaktest.SharedTestDataSource$1> is not abstract and does not override abstract method isWrapperFor(java.lang.Class<?>) in java.sql.Wrapper
/opt/sakai-trunk/search/search-impl/impl/src/test/org/sakaiproject/search/index/soaktest/SharedTestDataSource.java:[142,4] <anonymous org.sakaiproject.search.index.soaktest.SharedTestDataSource$1$1> is not abstract and does not override abstract method createStruct(java.lang.String,java.lang.Object[]) in java.sql.Connection
Updating these classes to include the 1.6 methods will allow the tests to run and will remain compatible with java 1.5