This is already being addressed by another jira

Re-assigning to Bryan for review.

Sorry about the timing, Bryan! Yes, this is a partial overlap with SAK-14230.

• It mostly duplicates the UserDirectoryService "getUsers(Collection userIds)" improvement, although because it sticks to single-table queries instead of joins, it reduces to a minimum of 2 queries as opposed to a minimum of 1 query.

• It misses the "getUsersByEids(Collection userEids)" improvement because Bryan was focusing on Roster rather than including Site Info as another trouble spot.

• It adds generic support to the SqlService for "select ... where ... in" queries when going against a single-table "entity". Assuming that we have a client in need of such support, this seems like an excellent idea (it doesn't apply for what I was doing because I used joins), with the addendum that it might be nice to embed the knowledge of database limits on the "in" list size in SqlService rather than making the client handle it.

I share Bryan's desire for someone other than myself to do some before-and-after scalability profiling on the change.

Also, Bryan, since you're likely the most knowledgeable code reviewer possible at this point , would you mind looking over the changes I have in the branches / patches that are attached to https://sakaiproject.atlassian.net/browse/SAK-14230#icft=SAK-14230 ? Thanks!

He' s out today, but he'll have a look. The specific issue is this:

http://jira.sakaiproject.org/jira/browse/SAK-14230

Most likely - could you have Ray look at this patch to see if there is any overlap? Thanks, L