Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Potential NPE and minor cleanup (static code review)

Description

http://qa1-nl.sakaiproject.org/codereview/bug_dashboard/findbugs_CORRECTNESS.html
NP_NULL_ON_SOME_PATH_EXCEPTION
org.sakaiproject.authz.tool.PermissionsAction 334
Possible null pointer dereference of myRole in org.sakaiproject.authz.tool.PermissionsAction.readForm(RunData, AuthzGroup, SessionState) on exception path

DM_BOOLEAN_CTOR org.sakaiproject.authz.tool.PermissionsHelperAction 129 org.sakaiproject.authz.tool.PermissionsHelperAction.initHelper(VelocityPortlet, Context, RunData, SessionState) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead

DM_NUMBER_CTOR org.sakaiproject.authz.tool.RealmsAction 223
Method org.sakaiproject.authz.tool.RealmsAction.buildListContext(SessionState, Context) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead

DLS_DEAD_LOCAL_STORE org.sakaiproject.authz.tool.RealmsAction 491
Dead store to $L6 in org.sakaiproject.authz.tool.RealmsAction.doSaveas(RunData, Context)

Activity

Jean-François Lévêque December 2, 2008 at 8:42 AM

2.5.x merge r54764

Jean-François Lévêque October 7, 2008 at 7:25 AM

No known way to check effects. PermissionsAction, PermissionsHelperAction and RealmsAction no longer shown on http://qa1-nl.sakaiproject.org/codereview/bug_dashboard/findbugs_CORRECTNESS.html

Stephen Marquard February 16, 2008 at 11:42 AM

r41248

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created February 16, 2008 at 11:30 AM
Updated October 27, 2009 at 2:56 PM
Resolved February 16, 2008 at 11:42 AM