Code Cleanup for BaseAuthzGroupService

Description

BaseAuthzGroupService/BaseAuthzGroup have various old-style code that could be cleaned up.

#1: This pair make use of a "private agreement" that their mutual classes can still be resolved even after a round trip to the ComponentManager. In particular the following line of code

if (m_lazy) ((BaseAuthzGroupService) (AuthzGroupService.getInstance())).m_storage.completeGet(this);

is repeated over a dozen times in the BaseAuthzGroup, which would be an impermissible cast if https://sakaiproject.atlassian.net/browse/SAK-12166#icft=SAK-12166 and following went ahead. It would also actually be a small performance improvement if the service were simply injected in the constructors to the group object since we would not incur the locking overhead of a CM trip.

#2: Various Java 5 updates - use of generic collections both in impl and API improve readability and type safety.

Activity

Show:

David Horwitz April 30, 2013 at 3:58 AM

On the basis that these have been untouched in some years and the asignee is no longer involved in Sakai, am marking them closed

Filter Maintainer December 15, 2007 at 9:03 AM

[Bulk Comment] This issue has a Fix Version set, however, it is an Unresolved issue. The Fix Version is being re-set to Unknown. Please use the Target Version field to indicate in for version of Sakai you plan to address this issue. Thank you.

Ryan Lowe November 14, 2007 at 10:51 AM

Branch for authz has been created:

https://source.sakaiproject.org/svn/authz/branches/SAK-12200

Commit access given to Antranig

Thanks!

Antranig Basman November 14, 2007 at 10:03 AM

Branch of authz with access to me, cheers.

Won't Fix

Details

Priority

Affects versions

Assignee

Reporter

Created November 14, 2007 at 10:02 AM
Updated March 23, 2022 at 2:56 PM
Resolved April 30, 2013 at 3:58 AM

Flag notifications