RSF unable to use sakai.filepicker helper in select mode
Description
When you call a helper from RSF, HelperHandlerHookBean sets things up so that requests go to the hellper until the helper returns. This sounds right, except when you realize that one helper may call another.The RSF hook continues sending activity to the initial helper, ignoring the fact that it's supposed to have moved to the helper.
The attached diff works for the call from the sakai-filepicker to sakai.resource.type.helper. However there is no guarantee that it will work in general.
I need this feature for a tool I'm developing. For the moment I'm using a patched copy of sakairsf. This isn't made easier by the fact that source for RSF 0.7.4 seems to be unavailable. I hacked together a build that would work, but this is going to make deployment of this tool dubious. When I built sakairsf-0.7.4-sakai_2.2.x.jar from the pom and src in the jar file, the result didn't work. I ended up using the original jar file and replacing just the class that changed.
The only way I can think of to test this fix is to use an applet that uses this feature. I'll be checking in an updated version of my contrib tool lesson builder later this weekend that does so. For the moment the pom file is configured to pull my hacked copy of the jar file from one of my servers.
Attachments
1
Activity
Show:
David Horwitz March 9, 2012 at 1:11 AM
Chuck can you confirm this is fixed in RSF 0.7.5?
Charles Hedrick February 17, 2012 at 8:57 AM
This problem is fixed in the most recent RSF. He took the code several months ago. I'm willing to fix RSF issues that cause me problems, but I'll need someone to install the code.
Megan May February 17, 2012 at 8:33 AM
Steve is moving onto another project and will not be working on these issues going forward.
When you call a helper from RSF, HelperHandlerHookBean sets things up so that requests go to the hellper until the helper returns. This sounds right, except when you realize that one helper may call another.The RSF hook continues sending activity to the initial helper, ignoring the fact that it's supposed to have moved to the helper.
The attached diff works for the call from the sakai-filepicker to sakai.resource.type.helper. However there is no guarantee that it will work in general.
I need this feature for a tool I'm developing. For the moment I'm using a patched copy of sakairsf. This isn't made easier by the fact that source for RSF 0.7.4 seems to be unavailable. I hacked together a build that would work, but this is going to make deployment of this tool dubious. When I built sakairsf-0.7.4-sakai_2.2.x.jar from the pom and src in the jar file, the result didn't work. I ended up using the original jar file and replacing just the class that changed.
The only way I can think of to test this fix is to use an applet that uses this feature. I'll be checking in an updated version of my contrib tool lesson builder later this weekend that does so. For the moment the pom file is configured to pull my hacked copy of the jar file from one of my servers.