From Nancy's result , this is a PASS

rSmart dev server
SmartSite@UCDavis - 2.6.4.0 - Sakai 2.6.2 - Server "ucddev1"

TEST PROCESS
set up gb as categories, points based
1 - created 2 categories, added items to each
2 - graded some on-line
3 - exported and re-named item lab 2 to lab 2a, comments to comments lab 2a
4 - graded real people > 10 point score and sakaistus <10 points
5 - imported
6 - popup says "one or more scores cannot be uploaded because they are not in the correct
format or because scores are higher than the maximum...entries have been highlighted in red" - ok
preview shows lab 2a rename BUT it's Unassigned instead of being in the original category.
there's not a lab 2 in the preview items list - ok?
7 - preview scores are highlighted and oddly, text is grey italicized , which makes sense as new item is
Unassigned and currently not included in grade...so lab 2's original association with it's category is not
passed to lab 2a <-------is this how it should be??
8 - after import, gb still has lab 2 in correct category, lab 2a has been imported and only the scores <10 for 2a - ok

QA RESULTS -
pass?
other than the foibles in 6 and 7, the final result looks good.

QA Test plan:

• Create a points gradebook with categories and a few grade items

• Export the gradebook

• In the export file, rename one of the assignments (make sure to change the comment name accordingly)

• Assign points that are greater than points possible for the grade item

• Import the the export file

You should see that the grade items that have "invalid" point entries that are marked red and an error message. See screen captures GRBK-629-1.png and GRBK-629-2.png
Also, the point values that are marked as red are "dropped" as the import is completed

The bugfix is as described above:

1. color the cell background red
2. show message, similar to errors, indicating that there are invalid grades
3. have a tool tip explaining the issue

I was able to do 1 and 2 but NOT 3.

The "auto" adjusting of total points possible for a Grade Item only occurs in cases where a new Grade Item is added via the import process.

e.g.
User adds new Grade Item to import file, or renames an existing one. In that case the GradeItem has an ItemId of "-1", which triggers the GradeItem's total points adjustment.

private boolean handleSpecialPointsCaseForItem(Item item, double d, ImportExportInformation ieInfo) {
boolean isFailure = false;
if (item != null) {
Double points = item.getPoints();
if (points != null) {
if (points.doubleValue() < d) {

if (item.getItemId() != null && item.getItemId().equals(Long.valueOf(-1l))) {
// Ensure that we have an int
d = Math.ceil(d);
// Round to the nearest hundred if d > 100,
// otherwise, round to the nearest ten
if (d > 100) {
d = d / 100;
d = Math.ceil(d);
d = d * 100;
} else if (d > 10) {
d = d / 10;
d = Math.ceil(d);
d = d * 10;
}
item.setPoints(d);
} else {
isFailure = true;
ieInfo.setInvalidScore(true);
}
}
}
}
return isFailure;
}