Ensure consistency of block item definitions between item and block parent
GENERAL
TESTING
GENERAL
TESTING
Description
We somehow ended up with db inconsistencies in templates, possibly as a result of prior template editing bugs, leading to child items in a block not all having the same scale as the block parent.
This can be shown in a db through this query:
select EVAL_TEMPLATE.ID As TemplateID, LEFT(EVAL_TEMPLATE.TITLE, 30), EVAL_TEMPLATE.LAST_MODIFIED, SAKAI_USER_ID_MAP.EID, TemplateItem.ID As TemplateItemID, Item.ID As ItemID, LEFT(Item.ITEM_TEXT, 20), TemplateItem.BLOCK_ID, Item.SCALE_FK As ItemScale, BlockItem.SCALE_FK As BlockScale from EVAL_TEMPLATEITEM TemplateItem inner join EVAL_TEMPLATEITEM Block ON TemplateItem.BLOCK_ID = Block.ID inner join EVAL_ITEM Item on TemplateItem.item_id = Item.ID inner join EVAL_ITEM BlockItem On Block.item_id = BlockItem.ID inner join EVAL_TEMPLATE On TemplateItem.template_id = EVAL_TEMPLATE.ID inner join SAKAI_USER_ID_MAP ON EVAL_TEMPLATE.OWNER = SAKAI_USER_ID_MAP.USER_ID where Item.SCALE_FK <> BlockItem.SCALE_FK and TemplateItem.template_id in (select TEMPLATE_FK from EVAL_EVALUATION) order by EVAL_TEMPLATE.ID, TemplateItem.ID;
The result is that questions will be rendered in delivery using the scale type of the block parent, but in reporting each question will be shown using its own scale type (which could vary from that of the block parent).
While this situation should in theory never arise, it would be good defensive programming practice and preserve data integrity to generate reports using the same logic as delivery, i.e. use the scale from the block parent for displaying the scale for each child item.
Activity
Show:
Lovemore Nalube July 12, 2011 at 12:41 AM
Changing priority to Major. If this is still an issue then re-prioritize it. Also un-assigning myself from it.
Lovemore Nalube May 13, 2010 at 3:10 PM
What kind of DB check/fix needs to be done here? I am wiling to work on this, I just need a guideline. Checking the latest schema, it seems this only affected templateitems made before June 2009. As Stephen points out, it would be good practice to guard against this.
Stephen Marquard July 30, 2009 at 4:02 AM
Don't think there is yet any startup code for checking this consistency, so am reopening (and editing title).
Aaron Zeckoski July 29, 2009 at 11:47 AM
I think we talked about handling this by fixing up the database on system start (which I had thought was now the case) If this is not the case then this should be reopened.
We somehow ended up with db inconsistencies in templates, possibly as a result of prior template editing bugs, leading to child items in a block not all having the same scale as the block parent.
This can be shown in a db through this query:
select EVAL_TEMPLATE.ID As TemplateID, LEFT(EVAL_TEMPLATE.TITLE, 30), EVAL_TEMPLATE.LAST_MODIFIED, SAKAI_USER_ID_MAP.EID, TemplateItem.ID As TemplateItemID, Item.ID As ItemID, LEFT(Item.ITEM_TEXT, 20), TemplateItem.BLOCK_ID, Item.SCALE_FK As ItemScale, BlockItem.SCALE_FK As BlockScale
from EVAL_TEMPLATEITEM TemplateItem inner join EVAL_TEMPLATEITEM Block ON TemplateItem.BLOCK_ID = Block.ID
inner join EVAL_ITEM Item on TemplateItem.item_id = Item.ID
inner join EVAL_ITEM BlockItem On Block.item_id = BlockItem.ID
inner join EVAL_TEMPLATE On TemplateItem.template_id = EVAL_TEMPLATE.ID
inner join SAKAI_USER_ID_MAP ON EVAL_TEMPLATE.OWNER = SAKAI_USER_ID_MAP.USER_ID
where Item.SCALE_FK <> BlockItem.SCALE_FK and TemplateItem.template_id in (select TEMPLATE_FK from EVAL_EVALUATION)
order by EVAL_TEMPLATE.ID, TemplateItem.ID;
The result is that questions will be rendered in delivery using the scale type of the block parent, but in reporting each question will be shown using its own scale type (which could vary from that of the block parent).
While this situation should in theory never arise, it would be good defensive programming practice and preserve data integrity to generate reports using the same logic as delivery, i.e. use the scale from the block parent for displaying the scale for each child item.