OSP 2.7 Code Review

Alan Berg has performed some static code review on OSP 2.7m2. The results are attached here. They include some hand-written comments.

m2_osp.txt - A set of bugs that should be fixed ASAP (certain NPEs, resource leaks, etc.). These should be tracked as JIRA tickets (maybe as an umbrella issue) and resolved.

m2_osp_literals.txt - A set of places where better practices could be applied (literal-first comparisons, factory over instantiation, etc.).

easy_wins_find_java.pl - Perl script to find/fix some of the simpler style issues. May want to use and verify changes to clean up some practice concerns.

# Change these lines at the top of the Perl script. $src should point to the working copy of the OSP source.

my $src="/home/alan/Desktop/m2/sakai-2.7.0-M2/osp";
my $DEBUG=1; # If 0 or less then modify source code. If greater than zero then just output to stdout what will be done