Issues

Select view

Select search mode

 
50 of 51

Statistics Chart setting not saving

Fixed

Description

Saving a change to the gradebook settings does not save the change for the "Statistics Chart" option. I could not test in a course with the option already on as it defaults to off. I tested this in DevMode using Eclipse for both 1.8.0, the version we are using in our production environment, and trunk.

Steps to replicate:

1) Go to settings screen and check "Statistics Chart"
2) Click Save or Save/Close
3) Reload Gradebook - this is essential, as just going back into the settings page again can show the setting as "checked" when it is not saved in the db
4) Go to settings screen and see stats chart not checked

I attached some screenshots of the before and after.

Attachments

3

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created April 30, 2013 at 11:30 AM
Updated May 2, 2013 at 5:11 PM
Resolved May 1, 2013 at 6:44 PM

Activity

Show:

Jon Gorrono May 2, 2013 at 5:11 PM

I've tested this pretty thoroughly in 1.9.0-a6 and it all looks good.... values are persisted on the client and the server as expected. As I stated above some of the more annoyone client-side state issues were addressed to some degree since 1.8.1 was released with 1.9.0 being the target.

couple things to keep in mind that you may already know:

  • back sure all the changes in the patch files are applied

  • grades will not be visible to students unless they are 'released'

  • in both the Students' view and the Instructors' view, you have to click on a grade item for the chart to appear.

Christopher Gross May 2, 2013 at 2:18 PM
Edited

That did it. Thanks

Jon Gorrono May 2, 2013 at 1:59 PM

There are actually two lines to uncomment... did you get them both? take a look at the patch

Christopher Gross May 2, 2013 at 9:11 AM

With gradebook.setShowStatisticsChart(Boolean.valueOf(isShowStatisticsChart)) active and not commented the DO_SHOW_STATISTICS_CHART value in the database is now updating as expected, however the instructor view of the settings page still always shows the statistics chart setting as not selected upon reload of the gradebook page. Also, I am still not seeing a statistics chart in the student view so this and the instructor view issue may be related.

Christopher Gross May 2, 2013 at 8:29 AM
Edited

If this is the case then this is still a bug because the GB2 trunk code still has this issue even in a Sakai 2.9 with this edu-services patch, which is what we are running.

Let me add what I have done to test. Before I did DevMode testing, I tested in a 2.9 instance which has the edu-services patch. I would make a save and then check the DO_SHOW_STATISTICS_CHART value for that gradebook in the database table. At no time did the value ever change from NULL. In fact, all of the thousands of rows in that table have that column as NULL and not a single one has a value. When I tried to manually change that value, GB2 for that course would hang on the settings page. Even if I switched the value back to it's original NULL, the settings page for GB2 in that site would still hang.

Loading...