Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Section text in Lessons Reorder has insufficient contrast

Description

One the Reorder page in Lessons, the Section text has insufficient contrast. It is white text on light gray and is very difficult to read.

However, it looks ok in dark theme, since the white text shows up on the dark gray in that theme.

Attachments

4
  • 09 Jan 2025, 04:08 PM
  • 15 Dec 2024, 06:19 AM
  • 31 Jan 2024, 08:13 PM
  • 31 Jan 2024, 08:13 PM

Activity

Show:

Andrea Schmidt January 9, 2025 at 4:21 PM

Thanks ! I will leave it be, then.

Sam Ottenhoff January 9, 2025 at 4:13 PM

The trashcan is no longer red on either trunk or 23x, and will create a new Jira for that.

 

The use of color to emphasize is generally not recommended and creates issues with dark/light themes. Unless you feel strongly that this should be red, I don’t see a need for a new Jira.

Andrea Schmidt January 9, 2025 at 4:07 PM
Edited

Verified the section text is visible (checked both light and dark mode): 23x: https://qa23-maria.nightly.sakaiproject.org/, build: dcb4ca36

The trashcan is no longer red on either trunk or 23x, and will create a new Jira for that.

 

image-20250109-160808.png

Wasi Khan December 15, 2024 at 6:19 AM

Verified on trunk.

image-20241215-061829.png

 

Server Information

  • Sakai Version: 25-SNAPSHOT

  • Server Time: Dec 15, 2024 1:18:51 AM EST

  • Server: ip-172-31-7-189

  • Build Info: e0aebbb4

Automation for Jira December 12, 2024 at 8:53 PM

A pull request has been created, "SAK-49706 Lessons fix reorder section colors", you can see it at https://github.com/sakaiproject/sakai/pull/13110

Fixed

Details

Priority

Affects versions

Fix versions

23 Status

QA Verification Pass

Components

Assignee

Reporter

Created January 31, 2024 at 8:13 PM
Updated January 9, 2025 at 4:21 PM
Resolved December 13, 2024 at 7:31 PM
Configure

Flag notifications