Section text in Lessons Reorder has insufficient contrast
Description
Attachments
- 09 Jan 2025, 04:08 PM
- 15 Dec 2024, 06:19 AM
- 31 Jan 2024, 08:13 PM
- 31 Jan 2024, 08:13 PM
Activity
Andrea Schmidt January 9, 2025 at 4:21 PM
Thanks @Sam Ottenhoff ! I will leave it be, then.
Sam Ottenhoff January 9, 2025 at 4:13 PM
The trashcan is no longer red on either trunk or 23x, and will create a new Jira for that.
The use of color to emphasize is generally not recommended and creates issues with dark/light themes. Unless you feel strongly that this should be red, I don’t see a need for a new Jira.
Andrea Schmidt January 9, 2025 at 4:07 PMEdited
Verified the section text is visible (checked both light and dark mode): 23x: https://qa23-maria.nightly.sakaiproject.org/, build: dcb4ca36
The trashcan is no longer red on either trunk or 23x, and will create a new Jira for that.
Wasi Khan December 15, 2024 at 6:19 AM
Verified on trunk.
Server Information
Sakai Version: 25-SNAPSHOT
Server Time: Dec 15, 2024 1:18:51 AM EST
Server: ip-172-31-7-189
Build Info: e0aebbb4
Automation for Jira December 12, 2024 at 8:53 PM
A pull request has been created, "SAK-49706 Lessons fix reorder section colors", you can see it at https://github.com/sakaiproject/sakai/pull/13110
One the Reorder page in Lessons, the Section text has insufficient contrast. It is white text on light gray and is very difficult to read.
However, it looks ok in dark theme, since the white text shows up on the dark gray in that theme.