When editing Preferences locks are not being cleared

Description

Warnings about duplicate locks are appearing in the logs for Preferemces.

This indicates that the locks are not being cleared on the previous edit for preferences.

It’s not clear which action has not been clearing the locks, so in this issue we go through all the locations preferences are being edited and ensure that the edit is either canceled on an exception or that it is committed in finally.

Activity

Show:

Andrea Schmidt February 24, 2024 at 2:23 AM

Verified on 23x: https://qa23-maria.nightly.sakaiproject.org/, build: ed922e8d

No lock messages in server logs

Andrea Schmidt October 17, 2023 at 10:28 PM

Verified on 24x: https://trunk-maria.nightly.sakaiproject.org/, build: 2ea87c8f

Was able to test LTI, changed the time zone, then launched the tool again. No lock messages for LTI tools either.

Andrea Schmidt October 16, 2023 at 10:34 PM

Tested on 24x: https://trunk-maria.nightly.sakaiproject.org/, build: bf52c253 , except for LTI. Will attempt to test LTI but there is an issue with deep linking. Will try it with single tools.

Automation for Jira October 11, 2023 at 2:56 PM

A pull request has been created, "SAK-49358 Preferences improved handling of edits", you can see it at https://github.com/sakaiproject/sakai/pull/11987

Fixed

Details

Priority

Affects versions

23 Status

QA Verification Pass

Components

Assignee

Reporter

Created October 11, 2023 at 2:47 PM
Updated February 27, 2025 at 4:27 PM
Resolved October 13, 2023 at 1:40 PM
Loading...