postem: No error messages displayed in Post 'Em.

Description

Issue: Post 'Em is supposed to give alerts when one of the following actions is taken:

  1. Trying to upload a file that is not .csv file type. You should get an alert, "Alert: The file [filename] that you uploaded is not a valid file type. Please make sure your file is saved as a *.csv file and try again."

  2. Trying to upload a file with a username of a student not in the site. You should get an alert, "Alert: The following usernames are not associated with participants in this site: [usernames listed] To continue, you must first add these participants to the site or remove the participants from the file."

  3. Clicking Post before selecting a file to upload. You should get an alert, "Alert: Please choose a file to post."
    In Sakai 11, none of these produces an error message for the user. The screen just refreshes. If a file with an incorrect mimetype or a csv file with an incorrect user listed was selected, its filename continues to display on the screen after it refreshes.

Steps to reproduce issue 1 (selecting file that is not .csv):

  1. Go to PostEm and click Add.

  2. Enter a Title

  3. Click Choose a CSV file or URL from Resources.

  4. Click Browse and select a file from your computer that is a different format than CSV (e.g. an image or .doc file).

  5. Click Continue.

  6. The page reloads, there is no error message indicating that you are trying to upload an incorrect file type:

  7. This is a regression from 10. In 10, you get an error message indicating, "Alert: The file [filename] that you uploaded is not a valid file type. Please make sure your file is saved as a *.csv file and try again."

Steps to reproduce issue 2 (selecting file that has incorrect students listed):

  1. Create a CSV file with some students listed who are not members of the site.

  2. Go to PostEm and click Add.

  3. Enter a Title.

  4. Click Choose a CSV file or URL from Resources.

  5. Click Browse and select the file you created in step 1.

  6. Click Continue.

  7. The page reloads, there is no error message indicating that you are trying to upload a file with students not in the site:

  8. This is a regression from 10. In 10, you get an error message indicating, "Alert: The following usernames are not associated with participants in this site: [usernames listed] To continue, you must first add these participants to the site or remove the participants from the file. "

Steps to reproduce issue 3 (clicking Post with no file selected): (This issue is on https://sakaiproject.atlassian.net/browse/SAK-31784#icft=SAK-31784)

  1. Go to PostEm and click Add.

  2. Enter a Title.

  3. Click Post.

  4. You should get an error message: "Alert: Please choose a file to post." but you don't.

Attachments

7
  • 19 Sep 2016, 03:39 PM
  • 24 May 2016, 01:50 AM
  • 24 May 2016, 01:50 AM
  • 23 May 2016, 04:00 PM
  • 23 May 2016, 03:58 PM
  • 23 May 2016, 03:48 PM
  • 23 May 2016, 03:44 PM

Activity

Show:

Matthew Jones September 22, 2016 at 7:01 PM

It also looks like this fix didn't get merged into 11.x after all either.

Matthew Jones September 19, 2016 at 3:35 PM
Edited

I'm seeing the error messages for case 1 and 2. I don't see the error message for case #3 on Sakai 10 either so I'm thinking of just breaking it out to a new issue. Can you verify on nightly that issues 1 and 2 are resolved? I opened https://sakaiproject.atlassian.net/browse/SAK-31784#icft=SAK-31784 for the 3rd issue.

(Attached my screenshot from trunk)

Alejandro González Jiménez July 25, 2016 at 5:36 AM

Tested in https://trunk-oracle.nightly.sakaiproject.org with 51.0.2704.106 m and still don´t get the expected error messages for three issues.

Regards

Matthew Jones May 24, 2016 at 11:15 AM

This looks similar to the redirect pattern that had to be removed in SAM-2766, removing these also fixes it. I think the better solution is more complex like this was in JSF 1.x

Alejandro González Jiménez May 24, 2016 at 1:50 AM
Edited

Hi!

In my opinion this error is not morpheus related. I´ve attached two screenshots.

https://jira.sakaiproject.org/secure/attachment/45506/Postem.png
https://jira.sakaiproject.org/secure/attachment/45505/Postem2.png

We have a regression but the error must be in the code of the tool

Regards!!

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Environment

Test servers: http://qa01-sakai.marist.edu:8080/portal https://qa11-mysql.nightly.sakaiproject.org/portal Browsers tested: Win 7 Firefox 46.0.1 Win 10 IE 11

Time tracking

20m logged
Created May 23, 2016 at 4:09 PM
Updated December 5, 2016 at 11:16 AM
Resolved September 19, 2016 at 3:37 PM

Flag notifications