Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

...

...

...

...

 

  1. Get a private fork on github ($$) where the security group could have all pull-requests that can not be seen from the outside and frequently get synched to the main repo.  
  2. When applying the patch, apply directly into origin to avoid a pull request. One can do this using the following:
Code Block
languagebash
titleGit commit to origin
git commit --author="Joe Smith <joe.smith@genericinstitution.edu>"

Basic steps:

  1. Open a Security JIRA.
  2. Unlike a typical patch that would go directly into a PR (pull request), the patch will be attached to the JIRA for review. 
  3. After patch is approved , commit it directly to Sakai trunk using (example below). When pushed, Git will have an entry for the author, as specified explicitly above, and the committer, whoever pushes in the patch.

...

Before the patch is ready

  1. Open a Security JIRA
  2. Unlike a typical patch that would go directly into a PR (pull request), the patch will be attached to the JIRA for review. Hence the need to apply the patch directly. 
git commit --author="Joe Smith <joe.smith@genericinstitution.edu>"