Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Sakai's BaseNotificationService has its limitations, notably that it requires any implementations of NotificationAction to be physically inside its component WEB-INF directory. Also, it uses manual manipulation of DOM objects for persistence, which is error-prone and yields object storage in the database as a lump of XML.

TO-DO

Here are a few less glamorous things that need doing. These are some suggestions that any volunteer developer could tackle.

  • event pack should not have to declare a dependency on conditions-impl. This is in there now in order to avoid a ClassdefNotFound error when we ask the NotificationService to reconstitute a ResourceReleaseRule from the database. It should be able to get a Class object from the Sakai ComponentManager instead. Look in BaseNotificationService for where it does this:
    Code Block
    
    m_action = (NotificationAction) Class.forName(className).newInstance();
    
  • GradebookExternalAssessmentServiceImpl should not use a static cover of the EventTrackingService. This is a case of doing the quick thing rather than the right thing. There's a Spring bean configuration file in there. We just need to modify it to add an injected EventTrackingService.